Drop node 18 and 20. Add 24#1882
Open
mm-kevcenteno wants to merge 12 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request drops support for Node.js 18 and 20, updating the minimum supported version to 22, and upgrades various dependencies. It replaces the deprecated punycode module with node:url's domainToASCII, adopts standard node: prefix imports, and modernizes cryptography calls using crypto.hash(). Additionally, the request client is refactored to use AbortSignal.timeout() instead of manual timeouts. A potential issue was identified in src/webServiceClient.ts where the caught error in the catch block is directly cast to Error, which can cause a runtime crash if the thrown value is not an object.
mm-kevcenteno
force-pushed
the
kevin/drop-old-node
branch
from
b0ee029 to
5ba0fdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package-lock.json files were rebuilt because of missing transitive dependencies that caused
npm cito fail